Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated the readme logo (#490) #498

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

heysolomon
Copy link
Contributor

Description

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@heysolomon thanks. With this new logo we can actually get rid of this entire HTML between line 1-9. Please use markdown to embed the logo, not <a>

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use only a Markdown without HTML and do other things. Please read action points of the issue #490 (comment)

So content should look like:

[![AsyncAPI JavaScript Parser](./assets/logo.png)](https://www.asyncapi.com)

Use this package to parse and validate AsyncAPI documents —either YAML or JSON— in your Node.js or browser application. Updated bundle for the browser is always attached to the GitHub Release.

and please change name of file new-brand.png to the logo.png.

@heysolomon
Copy link
Contributor Author

@heysolomon thanks. With this new logo we can actually get rid of this entire HTML between line 1-9. Please use markdown to embed the logo, not <a>

@derberg Okay, thanks. Let me correct that

@heysolomon
Copy link
Contributor Author

@magicmatatjahu Thank you. Let me correct that

@heysolomon
Copy link
Contributor Author

@derberg @magicmatatjahu i have just made the correction faf2b72

@derberg
Copy link
Member

derberg commented Mar 21, 2022

@heysolomon hey, I think you missed and please change name of file new-brand.png to the logo.png. comment from @magicmatatjahu

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@heysolomon
Copy link
Contributor Author

@heysolomon hey, I think you missed and please change name of file new-brand.png to the logo.png. comment from @magicmatatjahu

@derberg done f017ce1

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contribution!

@magicmatatjahu
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 03d8bb8 into asyncapi:master Mar 21, 2022
@heysolomon heysolomon deleted the new-readme-logo branch March 21, 2022 13:30
@heysolomon
Copy link
Contributor Author

LGTM! Thanks for contribution!

Thank you! :)

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants