-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated the readme logo (#490) #498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heysolomon thanks. With this new logo we can actually get rid of this entire HTML between line 1-9. Please use markdown to embed the logo, not <a>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use only a Markdown without HTML and do other things. Please read action points of the issue #490 (comment)
So content should look like:
[![AsyncAPI JavaScript Parser](./assets/logo.png)](https://www.asyncapi.com)
Use this package to parse and validate AsyncAPI documents —either YAML or JSON— in your Node.js or browser application. Updated bundle for the browser is always attached to the GitHub Release.
and please change name of file new-brand.png
to the logo.png
.
@derberg Okay, thanks. Let me correct that |
@magicmatatjahu Thank you. Let me correct that |
@derberg @magicmatatjahu i have just made the correction faf2b72 |
@heysolomon hey, I think you missed |
Kudos, SonarCloud Quality Gate passed! |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for contribution!
/rtm |
Thank you! :) |
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0-next-major.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description